Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for new MS SQL Server resource #136

Closed
nvthongswansea opened this issue Mar 17, 2021 · 3 comments
Closed

Suggestion for new MS SQL Server resource #136

nvthongswansea opened this issue Mar 17, 2021 · 3 comments
Assignees
@nvthongswansea
Labels
new-resource question
Milestone
v1.10.0

Comments

@nvthongswansea
Copy link
Contributor

Similar to #120, this suggestion is for new SQL server tf resource. The schema proposal will be provider later.
@nvthongswansea nvthongswansea changed the title uggestion for new SQL server resource(s) Suggestion for new SQL server resource(s) Mar 17, 2021
@nvthongswansea nvthongswansea mentioned this issue May 17, 2021
Merged
@bkircher bkircher changed the title Suggestion for new SQL server resource(s) Suggestion for new MS SQL Server resource May 20, 2021
@bkircher
Copy link
Contributor

Example here: https://github.com/gridscale/terraform-examples/tree/master/ms-sql-server

@bkircher bkircher added this to the v1.10.0 milestone May 20, 2021
bkircher pushed a commit that referenced this issue May 20, 2021
@nvthongswansea
Add MS SQL Server resource
f158938 
Adds a new resource gridscale_mssql.

* Add S3 backup feature
* Add GH Action workflow

Referenes:
- #161 
- #136
@bkircher
Copy link
Contributor

bkircher commented May 20, 2021 •
edited

@nvthongswansea

Looks good so far! Let's make the resource name "gridscale_sqlserver" instead of what we have now though. This is closer to the actual Microsoft product name and more distinguishable from "gridscale_mysql" resource.

@nvthongswansea
Copy link
Contributor Author

@bkircher renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvthongswansea nvthongswansea

Labels
new-resource question
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
3 participants
@bkircher @nvthongswansea @itakouna