Add k8s cluster resource #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are validation error samples: |
Fix error message when invalid k8s release is selected. Always check if keys of ParametersSchema exists.
bkircher
suggested changes
Mar 18, 2021
There was a problem hiding this comment.
Gets a "looks good to me so far" 😄 Just a couple of things that shouldn't be in the interface, I think.
@nvthongswansea @itakouna What release do we target with this 1.9.0? And how soon should we release this?
| @@ -77,6 +77,7 @@ func Provider() terraform.ResourceProvider { | |||
| "gridscale_snapshotschedule": resourceGridscaleStorageSnapshotSchedule(), | |||
| "gridscale_backupschedule": resourceGridscaleStorageBackupSchedule(), | |||
| "gridscale_paas": resourceGridscalePaaS(), | |||
| "gridscale_k8s": resourceGridscaleK8s(), | |||
There was a problem hiding this comment.
@itakouna please take a look. Thanks!
|
BTW, I really like the validation errors above. More of that please, Sir 💪 |
|
Ping @twiebe with a request for comment |
bkircher
reviewed
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new k8s resource to gridscale terraform provider #120.
What changes:
What it does:
k8s_release(e.g. 1.19), instead of inputtingservice_template_uuid. Optionally, the values ofk8s_releasecan be retrieved via gscloud.