Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update() should also take the options object #1235

Closed
jkusa opened this issue Mar 21, 2020 · 2 comments · Fixed by #1490 or #1491
Closed

update() should also take the options object #1235

jkusa opened this issue Mar 21, 2020 · 2 comments · Fixed by #1490 or #1491
Labels
type:enhancement

Comments

@jkusa
Copy link
Contributor

jkusa commented Mar 21, 2020

Subject of the issue

Currently, update() only takes a few positional option params. Just like addWidget(), update() should take an options object containing any item option.

Your environment

n/a

Steps to reproduce

n/a

Expected behaviour

n/a

Actual behaviour

n/a
@jkusa jkusa mentioned this issue Mar 21, 2020
Merged
@adumesny
Copy link
Member

see yahoo/ember-gridstack#62

@adumesny adumesny mentioned this issue May 24, 2020
Closed
adumesny added a commit to adumesny/gridstack.js that referenced this issue Nov 28, 2020
@adumesny
update(el, opts) re-write to take all options
443905d 
* fix gridstack#1235
* `update(el, opts)` re-write to take all `GridStackWidget` options
(not just x,y,width,height) and do everything efficiently.
* Fixed `locked()`, `move()`, `resize()`, `minWidth()`,etc...
to call update() instead which does all the constrain,
not just update attributes!
* update spec to test, and serialize demo to show improved feature
* OLD api to pass 4 params will work for now (console warning)
@adumesny adumesny mentioned this issue Nov 28, 2020
Merged
3 tasks
@adumesny
Copy link
Member

in upcoming 3.0 release!

adumesny added a commit to adumesny/gridstack.js that referenced this issue Nov 29, 2020
@adumesny
more update(el, opts) changes
ddf627f 
more for fix gridstack#1235
* moved the old individual routines to be hidden as update() does everything now
* updated doc which I forgot on last check in
* removed some old 0.5/0.6 backward compatible checks
@adumesny adumesny mentioned this issue Nov 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
2 participants
@jkusa @adumesny