Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.0 griditem change minWidth won't pass to engine #1359

Closed
rhlin opened this issue Sep 15, 2020 · 2 comments
Closed

v2.0.0 griditem change minWidth won't pass to engine #1359

rhlin opened this issue Sep 15, 2020 · 2 comments

Comments

@rhlin
Copy link
Contributor

rhlin commented Sep 15, 2020 •
edited

Subject of the issue

walk through the code, found that only maxWidth() in GridStack class api for modifing griditem min max data wound update the node.maxWidth . (see maxWidth)
maxHeight/minHeight/minWidth funtion call do not update the node.maxHeight/minHeight/minWidth, which might cause engine not cacluate right.
(see minWidth)

Your environment

  • version of gridstack.js: v2.0.0
  • which browser and its version: doesn't matter

Expected behaviour

node.minWidth = (val || undefined)

Actual behaviour

the node.minWidth wouldn't update
@rhlin rhlin changed the title vminWidth v2.0.0 griditem change minWidth won't pass to engine Sep 15, 2020
@rhlin
Copy link
Contributor Author

rhlin commented Sep 15, 2020

and another minor issue, GridstackOptions, the first letter of 'stack' , s should be capitalized

adumesny added a commit to adumesny/gridstack.js that referenced this issue Sep 15, 2020
@adumesny
GridStackOptions casing, minWidth() fix
50d3d73 
* fixed minWidth(), minHeight, maxHeight to set node value as well - see gridstack#1359
* correct GridStackOptions casing - see gridstack#1359
* rev 2.0.0-dev
@adumesny
Copy link
Member

thank you for finding the issues. feel free to make a code suggestion next time. fix coming now.

@adumesny adumesny mentioned this issue Sep 15, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhlin @adumesny