Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragging from below 2nd grid and grow upper grid too much #1558

Closed
adumesny opened this issue Jan 3, 2021 · 0 comments · Fixed by #1908
Closed

dragging from below 2nd grid and grow upper grid too much #1558

adumesny opened this issue Jan 3, 2021 · 0 comments · Fixed by #1908
Labels

Comments

@adumesny
Copy link
Member

adumesny commented Jan 3, 2021

Your environment

  • 3.1.3 H5 version
  • chrome windows

Steps to reproduce

https://jsfiddle.net/adumesny/63c7e4ps/
came from #1210

Expected behavior

when you drag an item from grid2 below into one above, grid1 should grow just enough to contain new item

Actual behavior

seems to grow repeatedly and insert at least 3 rows (seen worse)

20210103_091200.mp4
adumesny added a commit to adumesny/gridstack.js that referenced this issue Dec 29, 2021
* fix gridstack#992
* we now support dragging into and out of nested grids from parents
* nested.html was updated to showcase this, settings all grids to accept the same widgets. using CSS to differentiate nested items vs not for styling/demo purpose only.
* tested nested, float nad two.html - all seem to continue working (this was a lot of work to fine tune)

* also fix gridstack#1558 as we no longer cache the grid position (as we may move when items are placed elsewhere) but get it on every move to reflect latest data

Thank you [@arclogos132](https://github.com/arclogos132) for sponsoring it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant