Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging item out to bottom does not remove with maxRow #1570

Closed
NealonF opened this issue Jan 14, 2021 · 2 comments · Fixed by #1580
Closed

Dragging item out to bottom does not remove with maxRow #1570

NealonF opened this issue Jan 14, 2021 · 2 comments · Fixed by #1580

Comments

@NealonF
Copy link

NealonF commented Jan 14, 2021 •
edited

Subject of the issue

you can drag out to remove) from every side but bottom even though you have maxRow=6 (you can see drop feedback stays inside in that case)

Your environment

gridstack v3.1.3 with gridstack-jq-js and gristack.min.css as only references.
Chrome v87.0.4280.141 (Official Build) (64-bit)

Steps to reproduce

https://jsfiddle.net/adumesny/ks8gmqo4/

Expected behavior

Should remove item when dragged out from bottom of grid (as it does with every other side)

Actual behavior

Extends browser window and upon drop, goes back to spot where picked up.
@adumesny
Copy link
Member

3 separate bugs please...

@NealonF NealonF changed the title Dragging item out to bottom does not remove, item does not render when dragged into full grid, column:1 not working Dragging item out to bottom does not remove Jan 14, 2021
@adumesny adumesny changed the title Dragging item out to bottom does not remove Dragging item out to bottom does not remove with maxRow Jan 16, 2021
@adumesny
Copy link
Member

if you don't have maxRow the grid grows to fit so you never get the leave event, but it looks like we don't get leave even when max...

20210117_083644.mp4

works correctly when you have float:false (removes placeholder) though it requires being past the bottom by a lot

20210117_084011.mp4

adumesny added a commit to adumesny/gridstack.js that referenced this issue Jan 17, 2021
@adumesny
test for gridstack#1570
f0fa426
adumesny added a commit that referenced this issue Jan 17, 2021
@adumesny
Merge pull request #1577 from adumesny/develop
99ba04a 
test for #1570
adumesny added a commit to adumesny/gridstack.js that referenced this issue Jan 20, 2021
@adumesny
better drag-out/in from below heuristics
dd932b6 
* fix gridstack#1570
* we now have code to check if dragging outside of the grid (`engine.isOutside()`) which
checks for items past maxRow or added as last row in a real position vs being dragged out.
@adumesny adumesny mentioned this issue Jan 20, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better drag-out/in from below, cellHeight() CSS fix adumesny/gridstack.js
2 participants
@adumesny @NealonF