Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collision bug edge case: dragging large object over small ones #1676

Closed
adumesny opened this issue Mar 20, 2021 · 0 comments · Fixed by #1696
Closed

collision bug edge case: dragging large object over small ones #1676

adumesny opened this issue Mar 20, 2021 · 0 comments · Fixed by #1696
Labels
type:bug

Comments

@adumesny
Copy link
Member

adumesny commented Mar 20, 2021 •
edited

Subject of the issue

collision bug edge case: dragging large object over small ones

Your environment

  • h5 v4.0.1 chrome

Steps to reproduce

gridstack.js/spec/e2e/html/141_1534_swap.html#

issue

there is some some edge cases where collision is wrong - see video.
not wide spread, just this case.

part of #1094

20210320_151203.mp4
adumesny added a commit to adumesny/gridstack.js that referenced this issue Mar 29, 2021
@adumesny
collision: fix for single grid drag out/in
2b78ad3 
* fix gridstack#1676
* simplified the code so cursor is what make items leave/enter (else we can get double shadow)
* no longer need `engine.isOutside()` (we use cursor leave event)
or `_isCursorOutside` (use `_temporaryRemoved`)
* we also always use 'dropover'/'dropout' to track when we enter/leave to be consitent between multy grids and single one that doesn't accept widgets
(instead of sing acceptWidgets flag)
adumesny added a commit to adumesny/gridstack.js that referenced this issue Mar 29, 2021
@adumesny
collision: fix for single grid drag out/in
82e85b2 
* fix gridstack#1676
* simplified the code so cursor is what make items leave/enter (else we can get double shadow)
* no longer need `engine.isOutside()` (we use cursor leave event)
or `_isCursorOutside` (use `_temporaryRemoved`)
* we also always use 'dropover'/'dropout' to track when we enter/leave to be consistent between multi grids and single one that doesn't accept widgets
(instead of sing acceptWidgets flag)
@adumesny adumesny mentioned this issue Mar 29, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collision: fix for single grid drag out/in adumesny/gridstack.js
1 participant
@adumesny