Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first grid item is not animated when swapping positions with second same-size grid item #1678

Closed
kevinlandsberg opened this issue Mar 21, 2021 · 5 comments · Fixed by #1725
Closed

first grid item is not animated when swapping positions with second same-size grid item #1678

kevinlandsberg opened this issue Mar 21, 2021 · 5 comments · Fixed by #1725
Labels
type:bug

Comments

@kevinlandsberg
Copy link

Your environment

  • 4.0.1 html 5
  • chrome latest

Steps to reproduce

Just go to gridstack demo page and deactivate float and try to move first griditem

Expected behavior

Show show nice sliding animation like when you move all other grid items...

Actual behavior

when you swap first and second grid item it seems to not trigger animation effect
@adumesny
Copy link
Member

can you be more specific (actual demo or video) because this works for me

20210320_181657.mp4

@kevinlandsberg
Copy link
Author

@adumesny , i am talking about only the FIRST and SECOND grid-item. As soon as you move the FIRST grid-item onto the SECOND positition to swap the positions, there will be no animation triggered. ALL OTHER SWAP ANIMATIONS WORK FINE.

screen-capture.mp4

@adumesny
Copy link
Member

whoa, that is weird... wonder if it has to do with 1 column mode CSS... the only thing I can think of that make column 0 'special'.

@kevinlandsberg kevinlandsberg changed the title first grid item on moving shows no animation first grid item is not animated when swapping positions with second same-size grid item Mar 29, 2021
adumesny added a commit to adumesny/gridstack.js that referenced this issue Apr 12, 2021
@adumesny
item gs-x:0 not animating fix
501a92e 
* fix gridstack#1678
* make sure we set CSS rules for gs-x:0 and not just 1+
* turns out this never worked as file always did 1-12 styles.
@adumesny adumesny mentioned this issue Apr 12, 2021
Merged
3 tasks
@adumesny
Copy link
Member

fixed in next release. turns out this never worked as CSS always did 1-12 styles skipping gs-x:0 attribute!

Kevin, still waiting on that donation....

@kevinlandsberg
Copy link
Author

Yes, you will get this donation. Still no answer from financial office...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

item gs-x:0 not animating fix adumesny/gridstack.js
2 participants
@adumesny @kevinlandsberg