Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridstack from v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value #2357

Closed
zsolt-horvath opened this issue Jun 5, 2023 · 4 comments · Fixed by #2361

Comments

@zsolt-horvath
Copy link

zsolt-horvath commented Jun 5, 2023

Subject of the issue

From version 8 and above gridstack produces a weird, hard to debug "maximum call stack size exceeded" error and crashes the whole page when cellHeight is set with "rem". It is working properly with v7

Steps to reproduce

You can reproduce it in with the gridstack repo.

In the Gridstack repo go to: angular -> projects -> demo -> src -> app -> app.component.ts
Add for example: cellHeight: '23rem' to gridOptions in line # 36
Run the app locally, select the proper demo and try to drag&drop one of the grid items

@zsolt-horvath zsolt-horvath changed the title Gridstack > v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value Gridstack from v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value Jun 5, 2023
@adumesny
Copy link
Member

I'm not seeing any issue with 8.2.1 - I can drag items just fine (they don't resize though)
image

@adumesny
Copy link
Member

Oh never mind - draging the first item to push the other does cause issues...

adumesny added a commit to adumesny/gridstack.js that referenced this issue Jun 12, 2023
@adumesny
Copy link
Member

took a while to debug - though simple 1 liner fix.

fixed in next release. don't forget to donate if you find this lib useful!

@zsolt-horvath
Copy link
Author

Thank your for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants