Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setStatic not working! #481

Closed
artknight opened this issue Jul 22, 2016 · 4 comments
Closed

setStatic not working! #481

artknight opened this issue Jul 22, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@artknight
Copy link

I peeked at the source and I am seeing this code that seems to prevent the grid to be made static

 if (self.opts.staticGrid || typeof node == 'undefined' || node === null) {
                return;
            }

self.opts.staticGrid is set to true so this will return before doing anything

@radiolips
Copy link
Member

You're right. It looks like #431 broke this functionality. I'm pleased the jQuery-ui requirement was removed, but unfortunately it only accounted for static being set initially and not dynamically changed. We'll probably end up rolling back the change set. Thanks for identifying this.

@radiolips radiolips added this to the v0.2.6 milestone Aug 16, 2016
radiolips added a commit to radiolips/gridstack.js that referenced this issue Aug 16, 2016
@radiolips radiolips mentioned this issue Aug 16, 2016
@radiolips
Copy link
Member

@artknight This should be fixed in v.0.2.6. Could you let me know? It should still make sure jquery-ui is not a requirement, but should now work if you modify setStatic at any time.

@radiolips
Copy link
Member

@artknight I have no idea if this was fixed Aug 16, 2016, but it should be fixed now. setStatic was working, but staticGrid was not. And now it does work.

@artknight
Copy link
Author

this is fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants