new compact() method, tweak setColumn() #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* relayout grid items to reclaim any empty space * update two.html demo to have a compact buton, and test case
* improved code, now using gridEngine.addNode() instead of removeAll() + addWidget() which is much lighter now
* use a higher res layout when going up and cache is missing (better to downsample say from 12 then up-sample from 1!)
adumesny
changed the title
adumesny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
new compact() method
also (separate PR)
tweaks to setColumn() - #1098 part 2
(better to down-sample say from 12 then up-sample from 1!)
Checklist
yarn test)