HTML dnd check for setup ddResizable before enable/disable #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Dec 2, 2020
| @@ -24,7 +24,7 @@ export class GridStackDDNative extends GridStackDD { | |||
| public resizable(el: GridItemHTMLElement, opts: DDOpts, key?: DDKey, value?: DDValue): GridStackDDNative { | |||
| this._getDDElements(el).forEach(dEl => { | |||
| if (opts === 'disable' || opts === 'enable') { | |||
| dEl.ddResizable[opts](); | |||
| dEl.ddResizable && dEl.ddResizable[opts](); | |||
There was a problem hiding this comment.
hey I don't think this is right as is will not call enable if never created... which it needs to. Also move would need same fix.
if you look at the jquery version I force create for enable, and skip for disable/destroy
if (opts === 'enable') {
$el.resizable().resizable(opts);
} else if (opts === 'disable' || opts === 'destroy') {
if ($el.data('ui-resizable')) { // error to call destroy if not there
$el.resizable(opts);
}
}
|
thanks for the effort! let find a reproduceable case and I will fix it! |
|
taking this as partial fix. better one coming next. |
|
@adumesny thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle ddResizable enable/disable just like ddDraggable. Fixes #1505
Checklist
yarn test)