Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed item-content z-index #984

Merged
merged 1 commit into from Mar 29, 2019
Merged

removed item-content z-index #984

merged 1 commit into from Mar 29, 2019

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Mar 29, 2019

  • there is no need for the regular grid content to have a topmost z-index
    (dragging and placeholder still render on top unchanged)
    this was causing modal dialogs to grid content to be clipped and not render correctly

Checklist

  • Created tests which fail without the change (if possible)
    I test two.html and another testc ase and see no differences in z-ordering.

  • All tests passing (yarn test)

  • Extended the README / documentation, if necessary

image

instead of the correct modal (OK button from grid item).
image

* there is no need for the regular grid content to have a topmost z-index
(dragging and placeholder still render on top unchanged)
this was causing modal dialogs to grid content to be clipped and not render correctly
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.534% when pulling 980cd8f on adumesny:develop into f16ce8c on gridstack:develop.

@radiolips radiolips merged commit 118f050 into gridstack:develop Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants