Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "cheat codes" are not rejected and never timeout #185

Closed
crwood opened this issue Apr 9, 2019 · 1 comment
Closed

Invalid "cheat codes" are not rejected and never timeout #185

crwood opened this issue Apr 9, 2019 · 1 comment
Labels

Comments

@crwood
Copy link
Member

crwood commented Apr 9, 2019

Gridsync supports "cheat codes" as a means of (optionally) embedding the credentials needed to connect to a storage grid into the application bundle itself while still emulating the UX of a "real" magic-wormhole code during initial setup. Because cheat codes are intended to bypass the actual magic-wormhole functionality, however, and do not open up a real TCP connection, the standard connection timeout logic is never applied, thus leaving a user who incorrectly enters a 0-prefixed cheat code to wait indefinitely for a "connection" that will never complete.

Instead, Gridsync should check for and reject any/all 0-prefixed codes which to not correspond to valid cheat codes, informing the user immediately that the code is invalid -- and thereby preventing needless waiting and frustration in the event of a typo or incorrect cheat code.

@crwood
Copy link
Member Author

crwood commented Apr 9, 2019

Fixed via #186

@crwood crwood closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant