Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit handling subprocess pidfiles #569

Merged
merged 27 commits into from Oct 5, 2022

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Oct 2, 2022

There is an appropriate magic-folder release (22.10.0) but not yet for Tahoe-LAFS (using tahoe-lafs/tahoe-lafs#1221 would work).

@meejah
Copy link
Contributor Author

meejah commented Oct 3, 2022

I was hoping that Nix would "fix itself" once the cache or whatever updated. I don't know why it's not finding https://pypi.org/project/magic-folder/22.10.0/

@exarkun
Copy link
Contributor

exarkun commented Oct 3, 2022

I was hoping that Nix would "fix itself" once the cache or whatever updated. I don't know why it's not finding https://pypi.org/project/magic-folder/22.10.0/

We don't let dependencies float in the Nix build environment. If we want to see updates, we have to ask explicitly:

[exarkun@magnon:~/Work/python/tahoe-lafs]$ niv show pypi-deps-db
INFO: new sources.nix available: 24 -> 27
  Please run 'niv init' or add the following line in the nix/sources.nix file:
  # niv: no_update
pypi-deps-db
  branch: master
  description: Probably the most complete python dependency database
  homepage: 
  owner: DavHau
  repo: pypi-deps-db
  rev: 76b8f1e44a8ec051b853494bcf3cc8453a294a6a
  sha256: 18fgqyh4z578jjhk26n1xi2cw2l98vrqp962rgz9a6wa5yh1nm4x
  type: tarball
  url: https://github.com/DavHau/pypi-deps-db/archive/76b8f1e44a8ec051b853494bcf3cc8453a294a6a.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz

[exarkun@magnon:~/Work/python/tahoe-lafs]$ niv update pypi-deps-db
Update pypi-deps-db
  INFO: new sources.nix available: 24 -> 27
    Please run 'niv init' or add the following line in the nix/sources.nix file:
    # niv: no_update
Done: Update pypi-deps-db

[exarkun@magnon:~/Work/python/tahoe-lafs]$ niv show pypi-deps-db
INFO: new sources.nix available: 24 -> 27
  Please run 'niv init' or add the following line in the nix/sources.nix file:
  # niv: no_update
pypi-deps-db
  branch: master
  description: Probably the most complete python dependency database
  homepage: 
  owner: DavHau
  repo: pypi-deps-db
  rev: 2505eb53d85cd727c87611ee4aa35152821a12b2
  sha256: 0nhl0rzlp4fgzxb15pmnq14d0rzcwhvwn40vx7fnk41z9gwxcp4c
  type: tarball
  url: https://github.com/DavHau/pypi-deps-db/archive/2505eb53d85cd727c87611ee4aa35152821a12b2.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz

I can push this change if you want or you can reproduce it with https://github.com/nmattia/niv and niv update pypi-deps-db --rev 2505eb53d85cd727c87611ee4aa35152821a12b2.

@meejah
Copy link
Contributor Author

meejah commented Oct 5, 2022

@exarkun if you have the appropriate NixOS change handy, it would be great to push it here in the interests of time .. my nix setup isn't letting me install niv.

@exarkun
Copy link
Contributor

exarkun commented Oct 5, 2022

So apparently I thought I was commenting on a tahoe-lafs issue above. Gridsync has a Nix Flake now so actually I'm running nix flake lock --update-input pypi-deps-db. Nix Flakes are the new thing so ideally any projects we have that are still using Niv will at some point switch to this workflow.

I'm pushing the update now.

@exarkun
Copy link
Contributor

exarkun commented Oct 5, 2022

Eh ... no permission, so meejah#1

@crwood
Copy link
Member

crwood commented Oct 5, 2022

Thank you so much for all of your work on this, @meejah; merging...

@crwood crwood merged commit 694a4cb into gridsync:master Oct 5, 2022
@meejah meejah deleted the exit-handling-subprocess-pidfiles branch October 5, 2022 23:54
@crwood crwood mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants