Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specification of files to be included in server pack. Extends "Folders to be included in server pack". #67

Closed
Griefed opened this issue Jun 26, 2021 · 2 comments
Assignees
Labels
enhancement New feature, request or improvement

Comments

@Griefed
Copy link
Owner

Griefed commented Jun 26, 2021

  • What is the current behavior?
    Only folders inside the modpack can be specified for inclusion in the server pack. The user can not specify files to be included in the to-be-created server pack.

  • What is the wanted/requested behavior?
    Allow users to specify files inside their modpack to be included in the to-be-created server pack.

  • What are your reasons for making this feature request? Provide solid arguments on why I should start working on it.
    User jackboi03 on Discord messaged me with the request of adding a feature to include a whitelist in the server pack.
    Server packs created should be uploadable to Modpack sharing sites like CurseForge and anyone who downloads these server packs should be able to use them right from the get go.
    Including a pre-defined whitelist goes against that, as it would automatically restrict who can join the server created from the server pack in question.
    However. That being said. I may be able to expand a feature so it would allow users to include a whitelist, should they wish so.
    I'll see whether I can make it so a combination of "path/to/sourcefile:/path/to/server/pack/file" would allow the user to include any specific file as well.

@Griefed Griefed added the enhancement New feature, request or improvement label Jun 26, 2021
@Griefed Griefed self-assigned this Jun 26, 2021
@Griefed Griefed added the Working on it Indicates that work is being done on this issue/pr label Jul 11, 2021
@Griefed Griefed added this to In progress in Issue Tracker Jul 13, 2021
@Griefed Griefed moved this from In progress to Review in progress in Issue Tracker Jul 13, 2021
@Griefed Griefed moved this from Review in progress to In progress in Issue Tracker Jul 13, 2021
@Griefed
Copy link
Owner Author

Griefed commented Jul 16, 2021

Haven't gotten any negative feedback so far and all local tests worked flawlessly. Will probably merge and release in the next couple of days.

@Griefed Griefed removed the Working on it Indicates that work is being done on this issue/pr label Jul 18, 2021
@Griefed
Copy link
Owner Author

Griefed commented Jul 18, 2021

Available as of Release 2.1.0

@Griefed Griefed closed this as completed Jul 18, 2021
Issue Tracker automation moved this from In progress to Done Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request or improvement
Projects
No open projects
Issue Tracker
  
Done
Development

No branches or pull requests

1 participant