Build with dylib #7
Conversation
| @@ -20,18 +20,17 @@ | |||
| 11.0 | |||
| (progn | |||
| (run ./configure) | |||
| (run make libpython3.11.a)))) | |||
| (copy vendor/libpython3.11.a libpython.a) | |||
There was a problem hiding this comment.
I think that it's likely easier to just create a static library here and statically link it to both the static and the dynamic binding of taglessFinal (ie the artefact of binding.c)
vthemelis
force-pushed
the
dynamic-library
branch
from
1de312f
to
10fac79
Compare
lib/taglessFinal/dune
Outdated
| (foreign_stubs | ||
| (language c) | ||
| (names binding) | ||
| (flags :standard -Ivendor/Include -I.)) | ||
| (c_library_flags -lpython -lutil -lpthread) | ||
| (foreign_archives python)) | ||
| (c_library_flags -lutil -lpthread -lpython -L%{project_root}/_build/default/lib/taglessFinal/)) |
There was a problem hiding this comment.
This is hacky! I should be able to get the outputs of the rule in the context of the C build without adding the -L command.
There was a problem hiding this comment.
Yeah this creates hard dependency on where the build directory is. Any chance we could get the output without hardcoding the path?
There was a problem hiding this comment.
That's what I'm looking for but don't know of a way at the moment 😢. Hopefully there's a way and someone in ocaml/dune#8335 can show me.
vthemelis
force-pushed
the
dynamic-library
branch
from
10fac79
to
5d64af2
Compare
vthemelis
force-pushed
the
dynamic-library
branch
3 times, most recently
from
fb52098
to
1e8a5d9
Compare
|
LGTM except for the pathing in the build. Would also be nice if this change can be recorded on top of the |
Before this pathch, one could successfully do: ``` dune exec ./bin/pyre_parse.exe ``` but ``` dune exec ./bin/pyre_parse.bc ``` would fail. Now, both work. Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
vthemelis
force-pushed
the
dynamic-library
branch
from
1e8a5d9
to
9a6d84d
Compare
Thanks! I added a new entry to the I smoke tested this by adding my changes to an opam pin and running pyre's main executable and it seems to be working fine. The build is also green. |
First crack at fixing #6
See my comment here for more details: #6 (comment)
Before this patch, one could successfully do:
but
would fail.
Now, both work!