python#111488 fix cannot assign to expr

grigoriev-semyon · Jan 3, 2024 · abb1d3b · abb1d3b
1 parent 7c5b1f1
commit abb1d3b
Show file tree

Hide file tree

Showing 3 changed files with 350 additions and 249 deletions.
diff --git a/Grammar/python.gram b/Grammar/python.gram
@@ -968,7 +968,7 @@ for_if_clause[comprehension_ty]:
         CHECK_VERSION(comprehension_ty, 6, "Async comprehensions are", _PyAST_comprehension(a, b, c, 1, p->arena)) }
     | 'for' a=star_targets 'in' ~ b=disjunction c[asdl_expr_seq*]=('if' z=disjunction { z })* {
         _PyAST_comprehension(a, b, c, 0, p->arena) }
-    | 'async'? 'for' a=star_targets+ !'in' {
+    | 'async'? 'for' (bitwise_or (',' bitwise_or)* [',']) !'in' {
         RAISE_SYNTAX_ERROR("'in' expected after for-loop variables") }
     | invalid_for_target
 

diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
@@ -273,6 +273,22 @@
 Traceback (most recent call last):
 SyntaxError: cannot assign to function call
 
+>>> [x for a, b, (c + 1, d()) in y]
+Traceback (most recent call last):
+SyntaxError: cannot assign to expression
+
+>>> [x for a, b, (c + 1, d()) if y]
+Traceback (most recent call last):
+SyntaxError: 'in' expected after for-loop variables
+
+>>> [x for x+1 in y]
+Traceback (most recent call last):
+SyntaxError: cannot assign to expression
+
+>>> [x for x+1, x() in y]
+Traceback (most recent call last):
+SyntaxError: cannot assign to expression
+
 Comprehensions creating tuples without parentheses
 should produce a specialized error message: