Support for UAX#14 line breaking classes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case you want to read up on the specifcation it is located here. |
Extract the linebreak class for each code point from the Unicode text files and embed them in the database. Add a function for retrieving the linebreak class given a code point. Add a second function resolving the linebreak class according to the fallback outlined in LB1 of UAX#14. This takes UAX#14 revision 35 into account as revised for Unicode 8.0.0.
|
OK, looks good to me. |
grigorig
added a commit
that referenced
this pull request
Mar 7, 2016
Support for UAX#14 line breaking classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have recently been implementing support for the UAX#14 linebreaking algorithm
in mupdf. While doing so I needed to access the linebreaking
class for each code point and thought that this would make sense to have in ucdn.
This enlarges each UCDRecord by a single byte. I have also implemented support
in the python script to extract the information from the unicode-files and have
re-generated the database.
I hope this passes your code review, if not let me know how to help out in getting
this into ucdn proper. :)
/ Sebastian