Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: media/ted (HTTP download only) #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alech
Copy link

@alech alech commented Oct 13, 2015

I fixed the TED download. Unfortunately, RTMP does not seem to be supported by quvi (or is that just my build!?), so I fall back on the "native downloads", i.e. over HTTP. Unfortunately, max 480p only, then.

@hadess
Copy link

hadess commented Oct 13, 2015

RTMP URLs are supported just fine by quvi. quvi doesn't download the final links whether it's HTTP or RTMP, you'll need to pass the RTMP URL to something else, like GStreamer.

@alech
Copy link
Author

alech commented Oct 13, 2015

I am using quvi with git annex, which seems to do "quvi get $url". If I do that on a TED URL such as
http://www.ted.com/talks/vijay_kumar_the_future_of_flying_robots with the RTMP code enabled, I get:

error: protocol `rtmp' is not supported

This seems to come from the following code:
https://github.com/legatvs/quvi-tool/blob/master/src/get/lget.c#L53-L64

cURL does support RTMP and I am somewhat tempted to patch quvi to support it too, even though my C is worse than my Lua ;-)

How do we solve this problem beforehand, though? At the moment, TED support is broken completely, so I'd say having 480p downloads is better than nothing and once quvi supports RTMP, the RTMP code can be enabled?

@hadess
Copy link

hadess commented Oct 13, 2015

It's not supported in quvi-tool, so that's where the fix for that should be.

@alech
Copy link
Author

alech commented Oct 13, 2015

Hmmm, but with the existing libquvi-scripts code, nobody (using the library or quvi-tool) can download TED videos, which is clearly worse than 480p ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants