Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @export on h5writeAttribute S3 methods #89

Closed
LTLA opened this issue Aug 3, 2021 · 2 comments
Closed

Missing @export on h5writeAttribute S3 methods #89

LTLA opened this issue Aug 3, 2021 · 2 comments
Assignees

Comments

@LTLA
Copy link
Contributor

LTLA commented Aug 3, 2021

This causes problems like:

h5writeAttribute(cn, mat, "dimnames2")
## Error in UseMethod("h5writeAttribute") :
##   no applicable method for 'h5writeAttribute' applied to an object of class "character"
@grimbough grimbough self-assigned this Aug 3, 2021
@grimbough
Copy link
Owner

Thanks for pointing this out. Any idea why it doesn't trip up the unit tests in https://github.com/grimbough/rhdf5/blob/master/tests/testthat/test_h5writeAttributes.R ?

If I run the tests manually I see the error, but its fine in R CMD check or devtools::test(). Either way I'll get it fixed.

@LTLA
Copy link
Contributor Author

LTLA commented Aug 5, 2021

Probably because testthat fiddles with the package namespace to export all of the symbols (including those not exported) when tests are run via test_check(), but not when tests are run manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants