-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix UTF8 string encoding #101
Conversation
Thanks a lot for pointing this out. I'm inclined to go the other way and use the "UTF-8" notation, principle because that's the official name of the encoding. I see there's also some inconsistencies where this is set either via the |
Thanks for the feedback, I updated the PR to use |
Did you see that I made a pull request on your own repo with some additional changes? Those pass It'd be good if you could look over those, so we can keep in sync. I can't keep track of what you're doing with these force pushes. |
Apologies, I didn't get an email for your PR and so I missed it. I merged it now, thanks. |
No problem. I'll wait until the CI check have passed, and then merge this master and push to Bioconductor. That is, assuming the changes do what you want! |
Great, thanks. My usecase for the moment is pretty much covered by the h5createAttribute/h5writeAttribute part, so yeah, it does what I want :) |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 77.82% 77.85% +0.02%
==========================================
Files 35 35
Lines 1876 1892 +16
==========================================
+ Hits 1460 1473 +13
- Misses 416 419 +3
Continue to review full report at Codecov.
|
This has now been merged and should be available from Bioconductor in rhdf5 version 2.39.2 in the next day or so. Thanks a lot for the help. |
h5createAttribute/h5writeAttribute needed the argument to be "UTF-8" and passed it to H5Tset_cset, which needed the argument to be "UTF8". Therefore, setting the encoding to UTF-8 failed. This patch changes h5createAttribute and h5writeAttribute to accept "UTF8".