change product to hardcoded number fixes #1012 fixes #998 fixes #997 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-qbraid
force-pushed
the
remove_product_from_allocation
branch
from
e77d458
to
a6aeb3f
Compare
awvwgk
requested changes
Jun 11, 2024
…-lab#998 fixes grimme-lab#997 Signed-off-by: James H. Brown <james.h.brown@dartmouth.edu>
….harry.brown@gmail.com> Signed-off-by: James H. Brown <james.h.brown@dartmouth.edu>
Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com> Signed-off-by: James H. Brown <james.h.brown@dartmouth.edu>
Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com> Signed-off-by: James H. Brown <james.h.brown@dartmouth.edu>
james-qbraid
force-pushed
the
remove_product_from_allocation
branch
from
f013021
to
c17e46f
Compare
I agree. Didn't know if you wanted them explicitly defined for some reason. |
awvwgk
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same compilation error as reference in #1012 , #998, and #997.
This is clearly some sort of bug in gcc as it is clearly passing an array to product.
Unless I am misunderstanding something, changing to hardcoded numbers should not pose a problem. If desired, I could also do the explicit product. e.g.
(2*ewaldCutD(1) + 1)*(2*ewaldCutD(2) + 1)*(2*ewaldCutD(3) + 1)Closes #1012
Closes #998
Closes #997