Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign error fixed for unbiased frequencies in SPH calculations #388

Merged
merged 1 commit into from Nov 29, 2020

Conversation

sespic
Copy link
Contributor

@sespic sespic commented Nov 29, 2020

Fixed inverse sign of frequencies for unbiased SPH calculations

Signed-off-by: Sebastian Spicher <49548271+sespic@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #388 (e89d68d) into master (f0728b8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files         301      301           
  Lines       50570    50570           
=======================================
  Hits        20533    20533           
  Misses      30037    30037           
Impacted Files Coverage Δ
src/hessian.F90 0.00% <0.00%> (ø)
src/solv/model.f90 51.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0728b8...e89d68d. Read the comment docs.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sespic sespic merged commit 1b098d4 into grimme-lab:master Nov 29, 2020
@awvwgk awvwgk added this to the v6.4.0 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants