Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ONIOM and TAtomList #851

Merged
merged 5 commits into from
Aug 23, 2023
Merged

update ONIOM and TAtomList #851

merged 5 commits into from
Aug 23, 2023

Conversation

Albkat
Copy link
Contributor

@Albkat Albkat commented Aug 21, 2023

  1. add warning if the distances between added link atom (H) and any other atom is too short (smaller than H2) -> check_dist

  2. update man page

  3. allow for 0 in TAtomList (e.g. 1,2,0,12)

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@Albkat Albkat requested review from awvwgk and MtoLStoN August 21, 2023 16:17
@awvwgk
Copy link
Member

awvwgk commented Aug 21, 2023

Why do we need zeros in the atom list, this sounds like some out of bounds issue to me.

@Albkat
Copy link
Contributor Author

Albkat commented Aug 21, 2023

Why do we need zeros in the atom list, this sounds like some out of bounds issue to me.

So, the problem right now is that zeros in Atomlist will throw segfault. Alternatively, we could raise an error.

@awvwgk
Copy link
Member

awvwgk commented Aug 22, 2023

I think we should rather add checks to avoid adding zeros in the first place to the list.

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@Albkat
Copy link
Contributor Author

Albkat commented Aug 22, 2023

I think we should rather add checks to avoid adding zeros in the first place to the list.

I assume that performing a direct check is not possible since the TAtomList parser is explicitly composed of pure procedures. I've altered the error handling approach: now, whenever it encounters a non-integer value or zero, it throws an error. If you have any more insightful suggestions for enhancing this, I'd be glad to hear them.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then

@Albkat Albkat merged commit 7919bb5 into grimme-lab:main Aug 23, 2023
11 checks passed
@Albkat Albkat deleted the small_update branch August 23, 2023 10:56
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
* handle 0 in atom list

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>

* cleanup oniom.f90

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>

* update xcontrol docs for new oniom settings

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>

* small interatomic distances warning

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>

* handle 0 and any non-integer value as an error

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>

---------

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants