Dimer Projection Method DIPRO for xtb #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles, workflow and framework to new environment
… messy types 'calc' and 'input' in dipro.f to new framework.
…ontinue debugging.
…ved. Dipro is basically working. Next: opt fragment read-in from xcontrol.
… spins are not det autom in xtb.
…eshhold for orb consideration.
…din for that e-thresh and apply for output write.
…or readin for that e-thresh.
…or readin for that e-thresh. accidentally used git reset. try to recover this commuit.
…ulation to all combinations of orbs within thresh.
…ext: average over hole/electron transport and charge transfer.
…n up code and nice output.
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
|
I added a little commit to fix some of your building issues in a full-fledged version of xTB. However, it seems that your new mode is dependent on |
awvwgk
requested changes
Aug 28, 2023
MtoLStoN
requested changes
Aug 29, 2023
pull request revision. Mainly fixed error handling and global types.
awvwgk
reviewed
Sep 17, 2023
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
|
Looking over this, it should be stable now. However, maybe it would be a good idea to add a test for this module? |
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
|
Thanks for adding the test. I think we may merge this now. |
MtoLStoN
approved these changes
Oct 5, 2023
awvwgk
approved these changes
Oct 5, 2023
gorges97
pushed a commit
to gorges97/xtb
that referenced
this pull request
Mar 27, 2024
* Incorporate the Dimer Projection Method for xTB (DIPRO) --------- Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com> Co-authored-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com> Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIPRO is now available as runtype within the xtb framework. It calculates the electronic coupling integrals J_ab and J_ab,eff from a dimer geometry according to the definition in B.Baumeier, J.Kirckpatrick, D.Andrienko, PCCP 2010, 12, 11103. DOI: 10.1039/c002337j . Those couplings may further be used for the estimation of conductivities.