Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve debug compilation errors #907

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

Albkat
Copy link
Contributor

@Albkat Albkat commented Nov 21, 2023

CMake build in debug mode results in several runtime errors (with both gfortran v11.4.0 and ifort v2021.5.0):

  1. Race condition in dftd4.f90
  2. Out of bound exception in oniom.f90
  3. Dimension mismatch in molecule.f90

Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@Albkat
Copy link
Contributor Author

Albkat commented Nov 21, 2023

In addition, I tested the Meson build with in the debug mode. Unfortunately, the resulting binaries do not arise any exceptions during the runtime. It might be advisable to consider rewriting the meson.build script in the future.

@Albkat
Copy link
Contributor Author

Albkat commented Nov 21, 2023

Big thanks to @MtoLStoN and @marvinfriede for their assistance during the debugging process.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing.

@Albkat Albkat merged commit 9a76e94 into grimme-lab:main Nov 22, 2023
10 of 11 checks passed
@Albkat Albkat deleted the small_fixes branch November 22, 2023 16:15
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants