aISS docking update for next QCG version #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cplett <82893466+cplett@users.noreply.github.com>
Albkat
reviewed
Jan 26, 2024
src/docking/set_module.f90
Outdated
| @@ -245,11 +245,15 @@ subroutine set_directed(env,key,val,nat,at,idMap,xyz) | |||
| integer, allocatable :: list(:) | |||
| real(wp) :: ddum | |||
| logical :: ldum | |||
| real(wp), parameter ::au = 627.509541d0 | |||
There was a problem hiding this comment.
Suggested change
| real(wp), parameter ::au = 627.509541d0 | |
| use xtb_mctc_convert, only : autokcal |
src/docking/set_module.f90
Outdated
Comment on lines
310
to
319
| case('expo') | ||
| if (getValue(env,val,ddum).and.set2) directedset%expo(1) = ddum | ||
| set2 = .false. | ||
| case('prefac') | ||
| !Prefactor is given in kcal, but xtb energies are in hartree | ||
| if (getValue(env,val,ddum).and.set3) directedset%val(1) = ddum / au | ||
| set3 = .false. | ||
| case('midpoint') | ||
| if (getValue(env,val,ddum).and.set4) directedset%expo(2) = ddum | ||
| set4 = .false. |
There was a problem hiding this comment.
Since these instructions aren't documented in xcontrol.7.adoc, it might be beneficial to add them to the xtb-docs
Albkat
previously approved these changes
Jan 31, 2024
Albkat
approved these changes
Jan 31, 2024
gorges97
pushed a commit
to gorges97/xtb
that referenced
this pull request
Mar 27, 2024
* Update aISS docking for next generation QCG Signed-off-by: cplett <82893466+cplett@users.noreply.github.com> * Cleanup Signed-off-by: cplett <82893466+cplett@users.noreply.github.com> --------- Signed-off-by: cplett <82893466+cplett@users.noreply.github.com> Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of an optional attractive potential during the position screening of the
aISSalgorithm. This will be used to make the solute more attractive for QCG runs. It has the shape of an error function including three parameters that can be used to determine the strength, the width, and the turning point. They are provided via an input file and stored in thedirectedsetobject.