raman activities with adjustable wavelength and T #967
Conversation
Signed-off-by: benbaed <s6bebaed@uni-bonn.de>
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
| @@ -1778,6 +1778,18 @@ subroutine parseArguments(env, args, inputFile, paramFile, lgrad, & | |||
| case ('--alpha') | |||
| call set_elprop('alpha') | |||
|
|
|||
| case ('--raman') | |||
| call set_elprop('raman') | |||
There was a problem hiding this comment.
In the current state, only the electrical property is set to alpha (via redirect raman), but no Hessian calculation is conducted. I.e., no frequencies (and intensities) will be available.
One could add this easily via a call similar to: call set_runtyp('hess').
| @@ -1778,6 +1778,18 @@ subroutine parseArguments(env, args, inputFile, paramFile, lgrad, & | |||
| case ('--alpha') | |||
| call set_elprop('alpha') | |||
|
|
|||
| case ('--raman') | |||
| call set_elprop('raman') | |||
There was a problem hiding this comment.
Similar to the comment above, a switch to turn on PTB should be added:
call set_exttyp('ptb')
if (.not. get_xtb_feature('tblite')) then
call ptb_feature_not_implemented(env)
return
endif
There was a problem hiding this comment.
The intended principle behind --raman is in my opinion the combination of the flags --ptb --hess --alpha together with Raman-specific options like temperature and frequency of incident light.
There was a problem hiding this comment.
(The automatic redirect to --ptb follows from the fact that PTB is currently the only implemented method capable of calculating polarizabilities.)
There was a problem hiding this comment.
Good idea, but I'd still preserve --ptb as a requirement in case of the Raman implementation with any other tight-binding method.
There was a problem hiding this comment.
Also fine for me. However, it should be checked whether an error is produced if a call like --raman --gfn 2 or similar is used. (Something like: "Raman not implemented with this method".)
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
|
Looks good to me now! |
* raman activities with adjustable wavelength and T Signed-off-by: benbaed <s6bebaed@uni-bonn.de> * add raman CLI opts in man page Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> * Update set_module.f90 * auto hess + small raman check Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> --------- Signed-off-by: benbaed <s6bebaed@uni-bonn.de> Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> Co-authored-by: albert <92109627+Albkat@users.noreply.github.com> Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
add
ptbsetupvariablesraman_tempandraman_lambda