End to end tests #39
End to end tests #39
Conversation
|
I still have to add add some tests for binary and for bisecting. But please do review this PR meanwhile. |
andorp
force-pushed
the
38-end-to-end-tests
branch
3 times, most recently
from
0587f41
to
d74db04
Compare
andorp
force-pushed
the
38-end-to-end-tests
branch
from
a96cdcf
to
2986790
Compare
| -- defined options. All the $$$OUT$$$ template value replaced the output file. | ||
| -- Only one output file should be configured in the options as we can define | ||
| -- only one expected output. The output file should be text file of some sort. | ||
| evaluatePipelineTest input options expected ext params actionWith progressCallback = do |
There was a problem hiding this comment.
Why is the type signature missing? Is it too complicated?
There was a problem hiding this comment.
It is a local helper function called only once. If you are really think a type signature is necessary I'll add them, but at the time of the writing I didn't feel the need of adding the type signatures.
There was a problem hiding this comment.
In my opinion, it is always good to have type signatures for top-level functions. Makes the code more readable, makes the docs more understandable.
There was a problem hiding this comment.
Than I'll add that ugly ones :D
grin/src/Pipeline/Pipeline.hs
Outdated
| @@ -257,6 +257,8 @@ data PipelineOpts = PipelineOpts | |||
| , _poLintOnChange :: Bool | |||
| , _poTypedLint :: Bool -- Run HPT before every lint | |||
| , _poSaveBinary :: Bool | |||
| , _poRuntimeC :: FilePath | |||
There was a problem hiding this comment.
Why are runtime.c or primop.c sources special?
I'd rater store a list of c source files in general.
There was a problem hiding this comment.
As we dedicated them to be special before. I also like the list idea better. Chaging...
grin/src/Pipeline/Pipeline.hs
Outdated
| ("clang-7 -O3 prim_ops.c runtime.c %s.o -s -o %s" ++ if debugSymbols then " -g" else "") | ||
| grinOptCodeFile fname | ||
| ("clang-7 -O3 %s %s %s.o -s -o %s" ++ if debugSymbols then " -g" else "") | ||
| (_poPrimOpsC cfg) (_poRuntimeC cfg) grinOptCodeFile fname |
There was a problem hiding this comment.
Use the list of c source files here.
Solves #38