Extended syntax: syntax conversion fix #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer extracts variables into new variables.
Now it removes resulting dead bindings after substitution.
csabahruska
requested changes
Dec 16, 2019
| @@ -69,5 +69,8 @@ copyPropagation e = hylo folder builder (mempty, e) where | |||
| | val == lpat | |||
| , isConstant val | |||
| -> rightExp | |||
| -- left unit law ; cleanup x <- pure y copies | |||
There was a problem hiding this comment.
Write more detailed comment about the reason the dead variable removal is needed. It will not be obvious in the future.
andorp
reviewed
Dec 16, 2019
| @@ -125,16 +125,40 @@ instance Convertible Exp New.Exp where | |||
| convert exp = fst $ evalNameM exp $ flip anaM exp $ \case | |||
| (Program exts defs) -> pure $ New.ProgramF (map convert exts) defs | |||
| (Def name args body) -> pure $ New.DefF (convert name) (map convert args) body | |||
| {- NOTE: we assume Binding Pattern Simplification has been run | |||
|
|
|||
| {- NOTE: We assume Binding Pattern Simplification has been run, | |||
There was a problem hiding this comment.
Is there an easy way to check that assumption?
There was a problem hiding this comment.
Looking at the code snippet it is not clear, why it does the trick. Please could you explain it?
There was a problem hiding this comment.
This function is only called after nameEverything. The other cases are deliberately left out to get a runtime error, so we know that the conversion failed.
There was a problem hiding this comment.
I added a more detailed error message to the transformation.
csabahruska
approved these changes
Dec 16, 2019
andorp
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we address some of the problems that arose in #53 regarding the
Old -> NewAST conversion.See #32.