-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Interface #179
Comments
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
|
Original comment by |
Original comment by Attachments: |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Nothing like reviving an eight-year-old issue, but here goes! Like I ([johnsonn]) mentioned on Plans, I'm going to take a shot at creating a default mobile style for Plans. I know other people have been thinking about this, so I wanted to use this issue as a place for folks to discuss and keep an eye on progress. Here's my rough plan for how to make this happen. The first step is easy: add the missing Second, I want to add an option to the custom stylesheet preferences that's something like "Also use the custom stylesheet on mobile." The idea here is that, if you don't check that box, you'll get the default mobile style on screens smaller than a certain width. If you're happy with the responsiveness of your custom stylesheet, though, you can check that box, and we won't give you the default mobile styles. I've already put some of that infrastructure in place with changes in Finally—and most importantly—I want to take another crack at designing a really great mobile interface. I hacked together something that was at least passable on small screens a few years ago in niqjohnson/plans-styles, but I don't love it. For one thing, I threw it together pretty quickly and didn't get to a lot of refinements I wanted to make. For another, I'm a better designer than I was three years ago, so I need to redeem myself. For another another, since that was a custom user stylesheet, I had to try to do everything in CSS, which made some things just not possible. My goal with these default styles is to make no markup changes and keep Javascript to a bare minimum, but I am planning to use at least a little JS to do some things that can't be done in pure CSS (like a good nav menu). For now, I added my old mobile styles in So that's the plan. I have zero timeline for carrying out the plan. I'm going to try to chip away at things over the next few weeks, and I'll post updates here if anyone wants to take a look. Please please please don't be shy about giving feedback; I'm a designer in my day job, too, and I much prefer collaboration to designing in isolation. Here's what the mobile interface looks like with the changes I currently have in the
|
Progress! I started redesigning the mobile style from scratch with the reading a plan view. Here's what it looks like right now on my iPhone Xs: Next up:
|
Whew, been a while since I gave an update. Mostly that's because I redesigned the stupid mobile menu like 900 times. Here's what I've done since last time:
Here's what it's looking like now: Still a ways to go, but I'm pretty happy with the progress so far. Here's what's next on my list:
|
This is looking so good! Thinking about integration… what sort of effect does |
Major breakthrough thanks to CSS pointer events and counters—the little button in the lower right that will jump you to the next plan in your autoread list now shows the name of the next plan and a count of how many unread plans you have in your list: For real this time, I'm stopping on the mobile menu and moving on to styling some of the other screens. This is very exciting, though. @iangreenleaf, that's a good question about what |
@niqjohnson that sounds like an acceptable downside to me. The few stylesheets that do provide an acceptable mobile experience should be updateable to handle that change, and we'll mostly be serving this new style to mobile users anyways, so it shouldn't cause too much breakage. |
Also, I love that little jump button. |
I'm working on a new stylesheet and want it to work on my phone! Can we add I have never actually contributed to Plans, but I'd be thrilled to figure out the pull request. Any objections or words of advice/caution before I start? |
@mrwweb This shouldn't be a super difficult change, but I'm a bit concerned about breaking existing stylesheets. How do the built-in stylesheets handle it? Because Plans has multiple interfaces, this change would need to be made in both /views/templates/tableless/PlansPage.tpl.php and /views/templates/legacy/PlansPage.tpl.php. I could make a case for only modifying the former file ("tableless"); anyone who's serious about a CSS stylesheet should be using that interface. It could be possible to make this opt-in per stylesheet - maybe a string in the stylesheet URL that signifies "please send the |
@acohn I'll try to run some tests soon with a few default stylesheets. I like the idea of only serving that with the "tableless" interface which seems like a good compromise. If I had to guess the styles will go from "hard to use" to "hard to use, but different".
My gut says that it makes sense to keep this as simple as possible. Having recently tried a few stylesheets on my phone, the experience is bad enough that I doubt this would actually be breaking much for anyone. But if we have any real stats on that, I'd love to know. |
My vote is to set it on the tableless interface and just bite the bullet. I don't think we're doing ourselves any favors by leaving this out for a fairly tenuous backwards compatibility, and if any stylesheets do have issues, the folks on this thread can probably help figure out a fix. |
I just did a bit of testing and I'm even more bullish on making this change now. I think the worst case scenario is "broken in a new way but at least I can read it", while both Pastel Hell and Terminal get better on mobile with this change (all with the Postmodern interface). I really can't imagine anyone is using plans in any meaningful way with the current lack of the Pastel HellBeforeAfterTerminalBeforeAfterLibreBeforeAfter |
@mrwweb, one other stylesheet you might want to check out is the responsive one I hacked together that a lot of people ended up using, https://niqjohnson.github.io/plans-styles/mobile/css/mobile.css. I was too lazy to introduce the |
@niqjohnson Thanks for flagging that. I had missed that one. (You should add it to [css]!) Test looks good! All my tests are in Firefox with device mode and just looking at the Styles page. It's very possible I missed some stuff, but I'm pretty sure this should be representative of real-life. "Mobile"BeforeAfterPlans Login Screen (for kicks)BeforeAfterAfter with one CSS fiximg { max-width: 100%; } |
New pull request with this change is now available. Let me know if there's anything else I can do to get this ready for deployment. |
Two notes on this ticket:
|
I think closing this makes sense. At this juncture, I doubt that adding another interface is really going to be the best solution, and we'd probably be better served figuring out how to integrate any further improvements into the existing postmodern interface. |
Original issue reported on code.google.com by
ian.gree...@gmail.com
on 6 Apr 2010 at 10:57The text was updated successfully, but these errors were encountered: