Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icons and add manifest to improve installing/mobile experience #299

Open
mrwweb opened this issue Nov 27, 2023 · 1 comment
Open

Comments

@mrwweb
Copy link
Contributor

mrwweb commented Nov 27, 2023

With trends toward Progressive Web Apps, new support for installing websites in MacOS/iOS, etc. it strikes me as a good idea to add/update the following things to Plans:

  • Higher-res default favicon
  • New optimized icons for various OS's
  • A site.webmanifest file that defines name (Grinnell Plans), short_name (Plans), start_url (https://grinnellplans.com/home.php), and probably the display type (standalone?). I don't think defining a theme_color or background_color makes sense as that seems likely to clash with most stylesheets and light/dark preferences

Over time, this would improve the experience for people "installing" plans on their home screens/task bars/etc.

I can't think of a downside, but I am very curious if people can think of extra considerations or potential downsides. I'm happy to submit the PR if at least a couple people think it's worth doing.

@iangreenleaf
Copy link
Member

This all sounds like good stuff, and like it's unlikely to cause problems with anything else and therefore shouldn't require much regression testing. 👍 from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants