Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application.cr #58

Merged
merged 2 commits into from
May 24, 2023
Merged

Update application.cr #58

merged 2 commits into from
May 24, 2023

Conversation

yanecc
Copy link
Contributor

@yanecc yanecc commented May 19, 2023

Now the error Not Implemented: Crystal::System::Signal.trap (NotImplementedError) will occur at runtime on Windows. The platform-agnostic API is preferred.

The method Process.on_interrupt is preferred to support grip to work on Windows.
Fix expanded_path
@grkek grkek merged commit 9a8ade5 into grip-framework:core May 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants