Fix blocking calls preventing streaming #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
commented
Apr 22, 2024
| if process is not None: | ||
| return_code = process.poll() | ||
| if return_code is not None: | ||
| stdout, stderr = run_process.process.communicate() |
There was a problem hiding this comment.
This is the key change. communicate blocks, poll does not.
vasinov
approved these changes
Apr 22, 2024
SavagePencil
approved these changes
Apr 22, 2024
| uvicorn.run( | ||
| "griptapecli.core.skatepark:app", host=host, port=port, reload=False, workers=4 | ||
| ) | ||
| uvicorn.run("griptapecli.core.skatepark:app", host=host, port=port, reload=False) |
There was a problem hiding this comment.
what does workers default to?
There was a problem hiding this comment.
1 but I will explicitly set it in an upcoming PR.
| @@ -101,7 +103,7 @@ def list_structure_runs(structure_id: str) -> list[Run]: | |||
| ] | |||
|
|
|||
|
|
|||
| @app.patch("/api/runs/{run_id}") | |||
| @app.patch("/api/structure-runs/{run_id}") | |||
There was a problem hiding this comment.
did we change this in Cloud?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.