Set cloud base url #20
Conversation
griptapecli/core/skatepark.py
Outdated
| "GT_CLOUD_RUN_ID": run.run_id, | ||
| "GT_CLOUD_BASE_URL": str(request.base_url), |
There was a problem hiding this comment.
Is the right ordering? Or should they be before os.environ so they can be overridden by os envs?
There was a problem hiding this comment.
we want customer to be able to override, so this'd be a gotcha, no?
There was a problem hiding this comment.
I'm playing this back in my head, let me know if this is comprehensive and accurate:
- In Skatepark emulator, customer wants to override the base URL if they've selected a different URL or port. So having this up here and then overridden by os.environ makes sense.
- In Cloud, customer never wants to override the base URL, right? Or are there scenarios where they might?
- In all situations, what is the benefit to overriding the Run ID? Should that be explicit?
There was a problem hiding this comment.
I think rather than try to predict when a user may or may not want to override these environment variables it's better to just have a consistent behavior for overrides.
- We provide some system level environment variables (
GT_CLOUD_RUN_IDandGT_CLOUD_STRUCTURE_ID). - Then
os.environis layered on. - Then
structure.envis layered on. - Then
run.envis layered on.
If you want to get fancy and override these, use at your own risk. If they try to set values for resources they don't own, auth will block them anyways.
There was a problem hiding this comment.
That works for me. So what's the full set of changes we need to make to enshrine that?
There was a problem hiding this comment.
This is how it works with the current changes.
griptapecli/core/skatepark.py
Outdated
| "GT_CLOUD_RUN_ID": run.run_id, | ||
| "GT_CLOUD_BASE_URL": str(request.base_url), |
There was a problem hiding this comment.
I'm playing this back in my head, let me know if this is comprehensive and accurate:
- In Skatepark emulator, customer wants to override the base URL if they've selected a different URL or port. So having this up here and then overridden by os.environ makes sense.
- In Cloud, customer never wants to override the base URL, right? Or are there scenarios where they might?
- In all situations, what is the benefit to overriding the Run ID? Should that be explicit?
collindutter
force-pushed
the
feature/base-url
branch
from
32876c0
to
fc44a68
Compare
No description provided.