Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to fix TestOpenAiEmbeddingDriver to run in GitHub actions #52

Closed
vasinov opened this issue May 19, 2023 · 1 comment
Closed

Figure out how to fix TestOpenAiEmbeddingDriver to run in GitHub actions #52

vasinov opened this issue May 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@vasinov
Copy link
Member

vasinov commented May 19, 2023 •
edited

Tests in TestOpenAiEmbeddingDriver run correctly locally but hang on GitHub.

Current hypothesis is that pinecone.Index in PineconeVectorStorageDriver either makes requests that hang forever or mismanages thread pools.

Our current fix is to move those tests outside of unit into integration, which don't yet run on GitHub.
@vasinov vasinov added the bug Something isn't working label May 19, 2023
@vasinov vasinov mentioned this issue May 19, 2023
Closed
@collindutter collindutter mentioned this issue Jul 3, 2023
Merged
@collindutter
Copy link
Member

@vasinov it seems that you've already resolved this?

@vasinov vasinov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasinov @collindutter