Add MediaArtifact #520
Merged
Add MediaArtifact #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewfrench would you like to keep this PR open? |
|
Yes, I'll dust this off and we can get it in. It's still useful as we expand to other media artifact types. |
andrewfrench
force-pushed
the
french/multimedia-artifacts
branch
from
599a0fd
to
5bdccdd
Compare
andrewfrench
force-pushed
the
french/multimedia-artifacts
branch
from
18b95a2
to
d062878
Compare
collindutter
reviewed
Apr 8, 2024
Comment on lines
21
to
23
| value: Raw bytes representing media data. | ||
| name: Artifact name, generated using creation time and a random string. | ||
| mime_type: The mime type of the image, like image/png or audio/wav. |
There was a problem hiding this comment.
Docstring appears a bit out of sync with actual fields.
Comment on lines
28
to
29
| artifact_type: str = field(default="media", kw_only=True, metadata={"serializable": True}) | ||
| format: str = field(kw_only=True, metadata={"serializable": True}) |
There was a problem hiding this comment.
Do these need to be split out like this? Do they serve any purpose other than building mime_type? I think artifact_type is a bit confusing because it's really the media type.
There was a problem hiding this comment.
These attributes contribute to mime_type as well as artifact name. Independent format metadata in particular is useful for things like enforcing format limitations on model inputs.
collindutter
force-pushed
the
french/multimedia-artifacts
branch
from
c2f6650
to
2bbf49a
Compare
collindutter
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a MediaArtifact class. ImageArtifact as well as future types inherit from a common MediaArtifact to capture common fields and functionality like artifact naming and MIME type support.