Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claude 3 Image Query Support #700
Claude 3 Image Query Support #700
Changes from 21 commits
5b56352
c7496c0
afb28a5
0d8107c
da3e5e8
f46c9ca
e5e1221
059a4e2
8af40e5
9c4b5f2
685fba3
ca814c4
3565689
7c38119
41157b4
7bbdbd6
294dac1
fbee2d8
978c8b9
3ee66c1
8a2e640
5528638
ec6e7ea
91e3e0e
b70e373
f8fc43a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep it named as
max_tokens
for consistency with other Drivers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I saw a PR that updated
max_tokens
tomax_input_tokens
andmax_output_tokens
? Was that just when you are providing atokenizer
?I am fine with updating this to match the rest of the drivers, but I would say
max_output_tokens
is better because that is explicitly what it is. Is that the same for the other drivers as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that
max_output_tokens
is probably a better field name, but the other PR was only in the context of the Tokenizers, not the Drivers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other drivers have inputs as text, not images. so to clarify my question: are the other drivers that have
max_tokens
intended to be for the output tokens or the input tokens?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated back to
max_tokens