Output single artifact, move value to name #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
commented
Apr 1, 2024
griptape/tasks/actions_subtask.py
Outdated
| @@ -103,7 +101,9 @@ def run(self) -> BaseArtifact: | |||
| else: | |||
| results = self.execute_actions(self.actions) | |||
|
|
|||
| self.output = ListArtifact([TextArtifact(format_output(r)) for r in results]) | |||
| self.output = ListArtifact( | |||
| [TextArtifact(name=f"{r[0]} output: {r[1].to_text()}", value=r[1].to_text()) for r in results] | |||
There was a problem hiding this comment.
Is this the correct approach? Using name doesn't quite feel right.
There was a problem hiding this comment.
I think name should just be {r[0]} output.
vasinov
requested changes
Apr 2, 2024
griptape/tasks/tool_task.py
Outdated
| @@ -63,8 +63,8 @@ def run(self) -> BaseArtifact: | |||
| subtask.run() | |||
| subtask.after_run() | |||
|
|
|||
| if subtask.output: | |||
| self.output = subtask.output | |||
| if subtask.output and isinstance(subtask.output, ListArtifact): | |||
There was a problem hiding this comment.
Can just be if isinstance(subtask.output, ListArtifact).
griptape/tasks/actions_subtask.py
Outdated
| @@ -103,7 +101,9 @@ def run(self) -> BaseArtifact: | |||
| else: | |||
| results = self.execute_actions(self.actions) | |||
|
|
|||
| self.output = ListArtifact([TextArtifact(format_output(r)) for r in results]) | |||
| self.output = ListArtifact( | |||
| [TextArtifact(name=f"{r[0]} output: {r[1].to_text()}", value=r[1].to_text()) for r in results] | |||
There was a problem hiding this comment.
I think name should just be {r[0]} output.
vasinov
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ListArtifactfromToolTask. Consistent with old behavior.ActionsSubtasktoTextArtifact.nameinstead ofTextArtifact.value. This allows developers to have a formatted output in additional to the raw output (for parsing).