Add minItems to ToolkitTask actions schema #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
fix/min-input
branch
from
d7a63f2
to
781d6e6
Compare
collindutter
changed the title
collindutter
commented
Apr 2, 2024
| @@ -10,6 +10,133 @@ | |||
|
|
|||
|
|
|||
| class TestToolTask: | |||
| TARGET_TOOLS_SCHEMA = { | |||
There was a problem hiding this comment.
Originally added this to validate the existence of minItems in the schema, but now it is being added during prompt rendering. Can remove these tests, but I think there is value in having them.
collindutter
force-pushed
the
fix/min-input
branch
from
781d6e6
to
0407d08
Compare
collindutter
changed the title
vasinov
requested changes
Apr 2, 2024
griptape/tasks/actions_subtask.py
Outdated
| ) | ||
|
|
||
| self.actions.append( | ||
| self.__error_to_action(f"Activity input JSON validation error: {error_message}") |
There was a problem hiding this comment.
Can we raise a schema.SchemaError instead so it's more consistent with the rest of the validation logic?
collindutter
force-pushed
the
fix/min-input
branch
from
0407d08
to
b6a524d
Compare
vasinov
approved these changes
Apr 2, 2024
collindutter
force-pushed
the
fix/min-input
branch
from
b6a524d
to
332eee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.