Add new fields to events #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
commented
Apr 11, 2024
| @@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - `LocalFileManagerDriver` for managing files on the local file system. | |||
| - Added optional `BaseLoader.encoding` field. | |||
| - `BlobLoader` for loading arbitrary binary data as a `BlobArtifact`. | |||
| - `model` field to `StartPromptEvent` and `FinishPromptEvent`. | |||
| - `input_task_input` and `input_task_output` fields to `StartStructureRunEvent`. | |||
andrewfrench
approved these changes
Apr 11, 2024
Comment on lines
+12
to
+14
| input_task_input: Union[ | ||
| BaseArtifact, tuple[BaseArtifact, ...], tuple[BaseArtifact, Sequence[BaseArtifact]] | ||
| ] = field(kw_only=True, metadata={"serializable": True}) |
There was a problem hiding this comment.
Not for this PR, but maybe we should define all these artifact output options as a union type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #739
Also adds Structure output/input values to
Start/FinishStructureRunEvent