Add optional exception attribute to ErrorArtifact #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Fantastic, thank you for the PR! Could you also please add here?
|
Sure thing, added. |
|
Ah could you also add a section in Something like: |
collindutter
previously approved these changes
Apr 17, 2024
CHANGELOG.md
Outdated
| @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - `output_task_input` and `output_task_output` fields to `FinishStructureRunEvent`. | |||
| - `AmazonS3FileManagerDriver` for managing files on Amazon S3. | |||
| - `MediaArtifact` as a base class for `ImageArtifact` and future media Artifacts. | |||
| - Added optional `exception` field to `ErrorArtifact`. | |||
There was a problem hiding this comment.
Hyper nit: Added is not needed here. The other bullet points read with an implicit Added through the section header.
collindutter
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord channel back in March (handling content management policy error), adding optional exception attribute to ErrorArtifact.
This will allow to check Exception instance against eg. OpenAI exceptions to handle it properly in your application.