Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull cloud url from env var #756

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Pull cloud url from env var #756

merged 1 commit into from
Apr 23, 2024

Conversation

collindutter
Copy link
Member

No description provided.

zachgiordano
zachgiordano previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@zachgiordano zachgiordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

SavagePencil
SavagePencil previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@SavagePencil SavagePencil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question; will follow up in Slack

griptape/drivers/event_listener/griptape_cloud_event_listener_driver.py Show resolved Hide resolved
@collindutter collindutter force-pushed the feature/cloud-url branch 4 times, most recently from ad1a2de to 2ce0d9e Compare April 23, 2024 20:54
SavagePencil
SavagePencil previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@SavagePencil SavagePencil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open Q in there. If deliberate, go ahead and merge.

griptape/drivers/event_listener/griptape_cloud_event_listener_driver.py Outdated Show resolved Hide resolved
@collindutter collindutter merged commit 670616f into dev Apr 23, 2024
9 checks passed
@collindutter collindutter deleted the feature/cloud-url branch April 23, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavagePencil SavagePencil SavagePencil approved these changes

@zachgiordano zachgiordano Awaiting requested review from zachgiordano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@collindutter @SavagePencil @zachgiordano