Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pinecone@3 #763

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Update to pinecone@3 #763

merged 1 commit into from
Apr 30, 2024

Conversation

collindutter
Copy link
Member

Closes #754

@collindutter collindutter requested a review from a team April 29, 2024 18:39
@collindutter collindutter force-pushed the fix/pinecone-update branch 2 times, most recently from 16e5df1 to 7ff671f Compare April 29, 2024 18:55
CHANGELOG.md Outdated
@@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **BREAKING**: Removed `workdir`, `loaders`, `default_loader`, and `save_file_encoding` fields from `FileManager` and added `file_manager_driver`.
- **BREADKING**: Removed `mime_type` field from `ImageArtifact`. `mime_type` is now a property constructed using the Artifact type and `format` field.
- Moved [Griptape Docs](https://github.com/griptape-ai/griptape-docs) to this repository.
- Bumped `pinecone` from `^2` to `^3`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be a breaking change if people are using the old version of pinecone? or is this fully internal to Griptape implementation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is technically breaking if users are using the client natively. But if users are using it through Griptape there'd be no changes required. Will escalate to breaking just as a safety measure.

@collindutter collindutter merged commit df8b42b into dev Apr 30, 2024
8 checks passed
@collindutter collindutter deleted the fix/pinecone-update branch April 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Pinecone from 2 to 3
2 participants