Add structure run tool #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
requested changes
Apr 29, 2024
vachillo
reviewed
Apr 29, 2024
|
@collindutter @vachillo Thanks for the comments! Attempted to address everything. Lmk how it looks |
collindutter
requested changes
Apr 29, 2024
|
@collindutter good call, added a docs page and refactored based on comments! |
collindutter
requested changes
Apr 30, 2024
Comment on lines
82
to
99
| @property | ||
| def description(self) -> str: | ||
| if self._description is None: | ||
| from requests import get | ||
|
|
||
| url = urljoin(self.base_url.strip("/"), f"/api/structures/{self.structure_id}/") | ||
|
|
||
| response = get(url, headers=self.headers).json() | ||
| if "description" in response: | ||
| self._description = response["description"] | ||
| else: | ||
| raise ValueError(f'Error getting Structure description: {response["message"]}') | ||
|
|
||
| return self._description | ||
|
|
||
| @description.setter | ||
| def description(self, value: str) -> None: | ||
| self._description = value |
There was a problem hiding this comment.
Properties should come after class fields
| status = result.get("status") | ||
|
|
||
| wait_attempts = 0 | ||
| while status in ["QUEUED", "RUNNING"] and wait_attempts < self.structure_run_max_wait_time_attempts: |
| url = urljoin(self.base_url.strip("/"), f"/api/structure-runs/{structure_run_id}") | ||
|
|
||
| result = self._get_structure_run_result_attempt(url) | ||
| status = result.get("status") |
There was a problem hiding this comment.
This has the potential to be None. We should use a regular dictionary lookup or handle the None case if we ever expect it to be so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GriptapeCloudStructureRunClienttool for invoking Griptape Cloud Structure Run APIsBaseGriptapeCloudClient