Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code isn't C89 #34

Closed
craigholm opened this issue Oct 20, 2014 · 2 comments
Closed

Code isn't C89 #34

craigholm opened this issue Oct 20, 2014 · 2 comments

Comments

@craigholm
Copy link

The current mod_python code isn't compliant with C89. Among other things, this prevents it from building with VS2008 on Windows with Python 2.7.

The main issues seemed to be variables declared after statements in a block. For example, from requestobject.c:

static PyObject *req_build_wsgi_env(requestobject *self)
{

    request_rec *r = self->request_rec;
    apr_table_t *e = r->subprocess_env;
    PyObject *env, *v;
    const char *val;
    int i, j;

    env = PyDict_New();
    if (!env)
        return NULL;

    int rc = set_wsgi_path_info(self);
    ...
@grisha
Copy link
Owner

grisha commented Oct 29, 2014

Thanks @craigholm for pointing this out. I have not touched Windows in ages, but if you have a patch/PR, it would be most welcome!

@grisha
Copy link
Owner

grisha commented Dec 2, 2015

Closing for inactivity.

@grisha grisha closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants