SingleViewRecyclerAdapter doesn't need that ID consistency

grishka · Oct 2, 2023 · 352a548 · 352a548
1 parent d28dfe7
commit 352a548
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/appkit/build.gradle b/appkit/build.gradle
@@ -23,4 +23,4 @@ dependencies {
 	implementation 'me.grishka.litex:collection:1.1.0'
 }
 
-version = '1.2.13'
+version = '1.2.14'
diff --git a/appkit/src/main/java/me/grishka/appkit/utils/SingleViewRecyclerAdapter.java b/appkit/src/main/java/me/grishka/appkit/utils/SingleViewRecyclerAdapter.java
@@ -5,24 +5,24 @@
 
 import androidx.annotation.NonNull;
 import androidx.recyclerview.widget.RecyclerView;
-import me.grishka.appkit.FragmentStackActivity;
 
 public class SingleViewRecyclerAdapter extends RecyclerView.Adapter<SingleViewRecyclerAdapter.ViewViewHolder>{
 
 	protected final View view;
 	protected final int id;
+	protected boolean createdViewHolder=false;
 
 	public SingleViewRecyclerAdapter(View view){
 		this.view=view;
-		if(view.getContext() instanceof FragmentStackActivity fsa)
-			id=fsa.generateViewId();
-		else
-			id=View.generateViewId();
+		id=View.generateViewId();
 	}
 
 	@NonNull
 	@Override
 	public ViewViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType){
+		if(createdViewHolder)
+			throw new IllegalStateException("Can only create one instance of the view holder. parent="+parent+", viewType="+viewType);
+		createdViewHolder=true;
 		return new ViewViewHolder(view);
 	}