Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelines around support for legacy Python #107

Closed
PeterJCLaw opened this issue Apr 13, 2023 · 2 comments
Closed

Timelines around support for legacy Python #107

PeterJCLaw opened this issue Apr 13, 2023 · 2 comments

Comments

@PeterJCLaw
Copy link
Collaborator

Just wondering what the plans were for keeping supporting running this package under legacy Python?

As demonstrated by #106, doing so isn't free (even if it is relatively low effort), so it might be a good idea to consider dropping Python < 3.7 at some point.

It's worth noting that IPython, possibly the biggest package which depends in some form on asttokens hasn't supported < 3.5 for over 5 years now, which hopefully means that that isn't the driving reason to keep supporting the older versions.

@dsagal
Copy link
Member

dsagal commented Apr 14, 2023

The driving force for supporting Python2 is actually Grist (https://github.com/gristlabs/grist-core), which was the driving force for creating asttokens. Specifically, the reason we need to keep supporting Python2 is that Grist has users with documents created when Python2 was still the default (this was in turn driven by a choice sandboxing that only worked with Python2).

If the pain of supporting both version were greater, we could update the major version of asttokens, drop Python2 support, and say that any packages that need it have to use an older asttokens version. At this point, this seems a greater hassle than supporting both Python2 and Python3 :)

@PeterJCLaw
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants