Pinned minimum version of the six package #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is being installed the manager can ensure proper version in the dependencies list
|
|
I think the point is that |
dsagal
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have stumbled upon this issue, when migrating to python 3.11 in my project. I had
six==1.11.0pinned in our requirements and sinceasttokenssetup config does not specify minimum six version, that seemed to be OK. It is a good practice to always pin at least minimum needed version, when using some functions introduced in newer ones.I have pinned the version
>= 1.12.0because this is the first one to introduceensure_textfunction, that is being used inexecutingpackage. In my case the issue came from ipython (newest version) that is usingasttokensdeeper in its dependencies.